nb Core Community
May 22, 2012, 02:37:02 pm *
Welcome, Guest. Please login or register.

Login with username, password and session length
News: 1.2.3 +nb is now final and released

@new registrations. I will not allow any new registrations here as there are more (real person) spambots here than ever.... captcha proved to be ineffective.

After your registration, mail me at ( admin AT shinobilegends.com ) from the mail address you want to register. Provide some text about you and possibly your game.
 
   Home   Help Search Calendar Downloads Login Register  
Pages: [1]
  Print  
Author Topic: commentary exploit -> section can be altered  (Read 966 times)
Nightborn
Administrator
Sr. Member
*****

Karma: +20/-0
Posts: 307



View Profile WWW
« on: August 15, 2008, 09:42:29 pm »

an exploit has been demonstrated by somebody on my (and another server) by a "proof of concept" attack

here is the patch you need to prevent people from posting in any section they want:

diff commentary.php ../../core/lib/commentar
84,91c84
<                       else {
<                               //here we have the request to add a comment with content... check if the section is right, else somebody tries to inject somewhere else Wink
<                               if (rawurldecode(httpget('section'))!=$section) {
<                                       output("`\$Please post in the section you should!");
<                               } else {
<                                       injectcommentary($section, $talkline, $comment, $schema);
<                               }
<                       }
---
>                       else injectcommentary($section, $talkline, $comment, $schema);
556c549
<       $req = comscroll_sanitize($REQUEST_URI)."&comment=1&section=".rawurlencode($section);
---
>       $req = comscroll_sanitize($REQUEST_URI)."&comment=1";
Logged

It should be fixed, but it won't be easy and it won't be fast. If you want
to help - wonderful. But keep in mind that it will take months of wading
through the ugliest code we have in the tree. If you've got a weak stomach -
stay out. I've been there and it's not a nice place.

   - Al Viro
Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.11 | SMF © 2006-2009, Simple Machines LLC Valid XHTML 1.0! Valid CSS!